test that on- and addEventListener callbacks fire on passthrough
#117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that native window.XMLHttpRequest is restored in passthrough tests, even after pretender's reference to `_nativeXMLHttpRequest` is changed in the tests. Also adds tests that listeners added with `addEventListener` are called on a passed-through xhr. FakeXMLHttpRequest's `dispatchEvent` method must be called with the event (which must have a `type` key) instead of `(eventName, event)`.
trek
added a commit
that referenced
this pull request
Oct 5, 2015
test that `on`- and `addEventListener` callbacks fire on passthrough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes:
addEventListenerfrom firing on passed-through requestsIn the passthrough tests, there are a few places where
pretender._nativeXMLHttpRequestis changed in order to facilitate testing, but Pretender sets the window'sXMLHttpRequesttothis._nativeXMLHttpRequestin#shutdown. This resulted inwindow.XMLHttpRequestgetting incorrectly permanently changed to the stubtesXHRmethod when those tests callpretender.shutdowninteardown.FakeXMLHttpRequest's
dispatchEventmethodmust be called with the event (which must have a
typekey) instead of(eventName, event). When called with theeventNamestring as the first argument, the fake XHR never locates theaddEventListener-added listeners and so never calls them. This PR fixes the call todispatchEventto have the correct parameter and adds tests that callbacks added using both methods will be called.